Upgrade to Java 21 + Spring Boot 3.4.5 + Modern Build Tooling#173
Open
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Open
Upgrade to Java 21 + Spring Boot 3.4.5 + Modern Build Tooling#173devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Conversation
- Upgrade spring-boot-starter-parent from 3.3.3 to 3.4.5 - Upgrade java.version from 17 to 21 - Remove incorrect maven-compiler-plugin config (source/target 1.8) - Update mysql-connector-java to mysql-connector-j 9.1.0 - Update Maven wrapper distribution URL to Maven 3.9.9 - Update Dockerfile to maven:3.9-eclipse-temurin-21 and eclipse-temurin:21-jre-alpine - Replace deprecated MySQL8Dialect with MySQLDialect - Make mvnw executable Co-Authored-By: Arjun Mishra <arjunsaxmishra@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Devin Review
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project from Java 17 / Spring Boot 3.3.3 to Java 21 / Spring Boot 3.4.5, fixes the broken maven-compiler-plugin config, modernizes the MySQL connector dependency, updates the Maven wrapper and Dockerfile base images, and replaces the deprecated Hibernate dialect.
Changes:
3.3.33.4.51721source=1.8 / target=1.8(bug)java.versionvia parent POMmysql-connector-java:8.0.33mysql-connector-j:9.1.03.9.73.9.9maven:3.8.3-openjdk-17maven:3.9-eclipse-temurin-21openjdk:17-alpineeclipse-temurin:21-jre-alpineorg.hibernate.dialect.MySQL8Dialectorg.hibernate.dialect.MySQLDialectmvnwpermissionschmod +x)No application logic, tests, or architecture changes. No new dependencies added.
Build verified:
./mvnw clean compile -DskipTestspasses with Java 21.Review & Testing Checklist for Human
./mvnw clean compile -DskipTestspasses locally with JDK 21./mvnw clean testpasses with JDK 21 (H2 in-memory DB for tests)docker build -t bankapp .Notes
openjdkDocker images are deprecated;eclipse-temurinis the recommended replacement.mysql-connector-javaartifactId was deprecated in favor ofmysql-connector-jstarting with Connector/J 8.x+.MySQL8Dialectis deprecated in Hibernate 6+;MySQLDialectauto-detects the MySQL version at runtime.Link to Devin session: https://app.devin.ai/sessions/9cc80ee2cc43422b94a73384fd402ba2
Requested by: @Colhodm